-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to volcano 0.4.0 #887
Conversation
Please rebase and resolve the conflict. |
@@ -378,7 +378,7 @@ func (wh *WebHook) selfRegistration(webhookConfigName string) error { | |||
}, | |||
} | |||
|
|||
mutatingWebhook := v1beta1.Webhook{ | |||
mutatingWebhook := v1beta1.MutatingWebhook{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it has been renamed in a newer version of the k8s API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes long ago
) | ||
|
||
replace ( | ||
k8s.io/api => k8s.io/api v0.16.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which k8s version does v0.16.6
correspond to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.16.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the k8s related dependencies are 1.16.6 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
* Upgrade volcano to v0.4.0 * fix gen code * fiox build * fix test * update developer guide * fmt
Depend on #886